Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint, pointpainting): add diag publisher for max voxel size #9720

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

082a53f
Select commit
Loading
Failed to load commit list.
Open

feat(lidar_centerpoint, pointpainting): add diag publisher for max voxel size #9720

style(pre-commit): autofix
082a53f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 27, 2024 in 30s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.08 (9.51 -> 9.43)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method node.cpp: LidarCenterPointNode::LidarCenterPointNode
  • Complex Method node.cpp: LidarCenterPointNode::pointCloudCallback

Annotations

Check notice on line 436 in perception/autoware_image_projection_based_fusion/src/pointpainting_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Complex Method

PointPaintingFusionNode::postprocess has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 186 in perception/autoware_lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

LidarCenterPointNode::pointCloudCallback has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 111 in perception/autoware_lidar_centerpoint/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

LidarCenterPointNode::LidarCenterPointNode increases from 87 to 89 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.