fix(autoware_behavior_velocity_intersection_module): fix bugprone-branch-clone #9702
+2
−9
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Dec 27, 2024 in 46s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.09 (4.44 -> 4.36)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional scene_intersection.cpp: IntersectionModule::modifyPathVelocityDetail
✅ Improving Code Health:
- Complex Method scene_intersection.cpp: IntersectionModule::modifyPathVelocityDetail
- Lines of Code in a Single File scene_intersection.cpp
- Overall Code Complexity scene_intersection.cpp
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1111 to 1104, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
IntersectionModule::modifyPathVelocityDetail decreases in cyclomatic complexity from 50 to 49, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
IntersectionModule::modifyPathVelocityDetail has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.83 to 4.80, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading