Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump: add 7("111") when reading pvpanic device capability #4168

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heywji
Copy link
Contributor

@heywji heywji commented Sep 27, 2024

We have a new capability: normal shutdown requests through pvpanic. See https://gitlab.com/qemu-project/qemu/-/blob/master/docs/specs/pvpanic.rst?ref_type=heads and the patchset https://lore.kernel.org/qemu-devel/202 [email protected]/

ID: 2898

Signed-off-by: wji [email protected]

@heywji
Copy link
Contributor Author

heywji commented Sep 27, 2024

Test Result:

1-Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.pvpanic_event_check.q35 Finshed 2024-09-27 15:53:50 2024-09-27 15:56:27 PASS 156.591329
2-Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.pvpanic_event_check.q35 Finshed 2024-09-27 15:56:28 2024-09-27 15:59:01 PASS 153.246943
Summary:
Finshed=2, PASS=2

@heywji
Copy link
Contributor Author

heywji commented Sep 27, 2024

Hi @leidwang, Could you help review this patch as well? Thanks!

@@ -14,4 +14,7 @@
i440fx:
expected_cap = 1
q35:
expected_cap = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need set a default value for it?I am not sure if this test case only run on RHEL9/10,if not, we should set a default for other versions of OS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this case, we are only considering RHEL9 and RHEL10 tests.

@heywji heywji marked this pull request as draft October 11, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants