refactor: pydoll v2 #132

thalissonvs · 2025-05-28T06:30:02Z

Refactoring Pull Request

Refactoring Scope

All codebase

Description

This refactoring aims to facilitate future maintenance. The file structure was reorganized for better readability, and type hints were added to improve robustness.

API Changes

No changes to public API
Public API changed, but backward compatible
Breaking changes to public API

Testing Checklist

Existing tests updated
New tests added for previously uncovered cases
All tests pass
Code coverage maintained or improved

Checklist before requesting a review

My code follows the style guidelines of this project
I have performed a thorough self-review of the refactored code
I have commented my code, particularly in complex areas
I have updated documentation if needed
I have run poetry run task lint and fixed any issues
I have run poetry run task test and all tests pass
My commits follow the conventional commits style

…implicity in its operations

…ucture

…arity

…s class

…erCommands

…ownloads

…rity

…sions

…ture

…nd clarity

thalissonvs · 2025-05-28T06:35:45Z

pydoll/browser/managers/browser_options_manager.py

+        else:
+            raise InvalidOptionsObject()


remove this

thalissonvs · 2025-05-28T06:39:05Z

pydoll/browser/tab.py

+            if response['result']['result']['value'] == 'complete':
+                break
+            if asyncio.get_event_loop().time() - start_time > timeout:
+                raise asyncio.TimeoutError('Page load timed out')


create a custom exception

cleitonleonel · 2025-05-28T12:58:00Z

Refactoring Pull Request

Refactoring Scope

All codebase

Description

This refactoring aims to facilitate future maintenance. The file structure was reorganized for better readability, and type hints were added to improve robustness.

API Changes

No changes to public API

Public API changed, but backward compatible

Breaking changes to public API

Testing Checklist

Existing tests updated

New tests added for previously uncovered cases

All tests pass

Code coverage maintained or improved

Checklist before requesting a review

My code follows the style guidelines of this project

I have performed a thorough self-review of the refactored code

I have commented my code, particularly in complex areas

I have updated documentation if needed

I have run poetry run task lint and fixed any issues

I have run poetry run task test and all tests pass

My commits follow the conventional commits style

Hi, there are many changes and a major refactoring. First of all, I would like to thank you for your commitment and dedication in keeping this project active. The changes seem very good to me, at least in the critical parts of the keyboard events module, the clarity obtained with this refactoring is very clear, but your tests seem to break when importing the commands module:

tests/test_browser_commands.py:1: in <module>
from pydoll.protocol.commands import BrowserCommands
E ModuleNotFoundError: No module named 'pydoll.protocol.commands'

thalissonvs added 30 commits April 21, 2025 21:25

refactor: refactor the InputCommands class to enhance clarity and s…

4eec595

…implicity in its operations

refactor: rename insert_text to paste_text and remove unused files

7a6b291

refactor: move command files to the protocol directory for better str…

3e04c0d

…ucture

refactor: refactor import paths to use the protocol submodule structure

70ba3f5

refactor: refactor element imports and remove deprecated element file

cc7c8fe

refactor: refactor browser modules to use the new chromium structure

9e1b6af

refactor: refactor BrowserType import to a common constants module

849623b

refactor: refactor connection imports and rename manager files for cl…

472bea7

…arity

refactor: refactor browser command constants to use Command class type

8cce6ef

refactor: refactor command structures and introduce base CommandParam…

5d5090f

…s class

feat: add response classes for browser window target retrieval

2faad4a

refactor: refactor command methods to specify response types in Brows…

12829a3

…erCommands

refactor: refactor execute_command to use type annotations for clarity

5e18727

refactor: add command and response types for protocol implementation

fa38502

refactor: add browser command methods for version, permissions, and d…

00eab4f

…ownloads

refactor: refactor imports for better organization and readability

13a6d7f

refactor: rename command and response modules for better clarity

a832393

refactor: refactor command structures for better organization and cla…

1a34edd

…rity

refactor: remove unused enum imports and rename base_types module

4aecaae

refactor: add enums for window states, download behaviors, and permis…

7910ddd

…sions

refactor: refactor fetch command templates to use Command class

280daa8

feat: add enums for cookie priorities, connection types, and encodings

a9b8ce9

refactor: refactor import statement for CommandParams module path

eaa4c48

refactor: refactor import and rename EnableParams to FetchEnableParams

c457935

feat: add network command types and parameters for cookie management

ea6f01f

feat: organize command types into structured imports and exports

25c459f

refactor: refactor import statements for consistency in response types

70b9b91

refactor: refactor import statements for better readability and struc…

d66c6c6

…ture

feat: add TypedDict definitions for network response types

5fd8a85

refactor: refactor response imports and update __all__ definitions

4e8169e

thalissonvs added 24 commits May 26, 2025 18:40

feat: add DomEvent enumeration for Chrome DevTools Protocol events

8ef0a6a

feat: add FetchEvent enumeration for Chrome DevTools Protocol events

172e49b

feat: add InputEvent enum for Chrome DevTools input events

5de5178

feat: add NetworkEvent enumeration for Chrome DevTools Protocol events

9357f32

feat: add PageEvent enumeration for Chrome DevTools Protocol events

6dd8a0f

feat: add RuntimeEvent enumeration for Chrome DevTools Protocol events

d9e3ba1

feat: add StorageEvent enumeration for Chrome DevTools Protocol events

45d723e

feat: add TargetEvent enum for Chrome DevTools Protocol events

f4a78d5

feat: add Event TypedDict for standardized event structure

fb58b8c

feat: refactor Keys class to Key and add utility methods for enums

8003cd1

refactor: refactor type hints for event callback parameters and options

db115dd

feat: intuitive way to interact with iframes

680485e

refactor: rename method for better clarity in captcha element handling

e579332

refactor: refactor element finding methods for enhanced flexibility a…

d7af0f8

…nd clarity

docs: add detailed docstrings for XPath and selector methods

cf533a5

refactor: refactor message handling to support multiple message types

47a9a7e

refactor: use message.get('id') for safer ID checks in response

40aeaae

style: refactor method signatures and clean up docstring formatting

eb23565

build: add mypy exclusion for test directory in configuration file

d4a3799

ci: add MyPy CI workflow for type checking Python code

0e170be

ci: add type installation step for mypy in workflow configuration

3e443b1

build: update mypy configuration to install types for pydoll package

91ead61

build: update mypy installation command to include the -y flag

6e2d4e8

build: update mypy workflow to install types non-interactively

5ce42fd

thalissonvs self-assigned this May 28, 2025

thalissonvs added the refactor label May 28, 2025

thalissonvs commented May 28, 2025

View reviewed changes

thalissonvs requested a review from cleitonleonel May 28, 2025 06:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: pydoll v2 #132

refactor: pydoll v2 #132

Uh oh!

thalissonvs commented May 28, 2025

Uh oh!

thalissonvs May 28, 2025

Uh oh!

thalissonvs May 28, 2025

Uh oh!

cleitonleonel commented May 28, 2025

Refactoring Pull Request

Refactoring Scope

Description

API Changes

Testing Checklist

Checklist before requesting a review

Uh oh!

Uh oh!

Uh oh!

refactor: pydoll v2 #132

Are you sure you want to change the base?

refactor: pydoll v2 #132

Uh oh!

Conversation

thalissonvs commented May 28, 2025

Refactoring Pull Request

Refactoring Scope

Description

API Changes

Testing Checklist

Checklist before requesting a review

Uh oh!

thalissonvs May 28, 2025

Choose a reason for hiding this comment

Uh oh!

thalissonvs May 28, 2025

Choose a reason for hiding this comment

Uh oh!

cleitonleonel commented May 28, 2025

Refactoring Pull Request

Refactoring Scope

Description

API Changes

Testing Checklist

Checklist before requesting a review

Uh oh!

Uh oh!