Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-Skylake Ubuntu builds #3235

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix non-Skylake Ubuntu builds #3235

merged 1 commit into from
Nov 13, 2024

Conversation

nazar-pc
Copy link
Member

I hate such programming languages.

It literally printed this and moved on like nothing happened:

#20 0.474 /bin/sh: 1: [: =: argument expected

But the logic was completely different! It somehow ended up compiling for Skylake processors by the looks of it 🤯

Code contributor checklist:

Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbelievable... 🙃

@nazar-pc nazar-pc added this pull request to the merge queue Nov 13, 2024
Copy link
Member

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...

Merged via the queue into main with commit d0dd634 Nov 13, 2024
8 checks passed
@nazar-pc nazar-pc deleted the fix-non-skylake-builds branch November 13, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants