Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase state sync retries #3222

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Increase state sync retries #3222

merged 1 commit into from
Nov 8, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Nov 8, 2024

It wouldn't hurt doing more attempts, but might help some users. Looks like large genesis state makes it difficult for some users to download it an situation will only get worse over time.

Code contributor checklist:

@nazar-pc nazar-pc added this pull request to the merge queue Nov 8, 2024
@liuchengxu
Copy link
Contributor

Perhaps the proposal in polkadot-fellows/RFCs#112 can be considered to improve the state sync performance for the short term. The patch is super simple if we don't take the backward compatibility into account (not sure if it's too late for network breaking changes though), just a few change lines liuchengxu/polkadot-sdk@2556fef, but the improvement is significant.

@nazar-pc
Copy link
Member Author

nazar-pc commented Nov 8, 2024

Yes, I'm following that proposal and already considered patching out fork. We just launched mainnet though, so we'll have to have some sort of compatibility layer.

Merged via the queue into main with commit 62cc37a Nov 8, 2024
8 checks passed
@nazar-pc nazar-pc deleted the increase-state-sync-retries branch November 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants