Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an initial gateway RPC crate #3139

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add an initial gateway RPC crate #3139

merged 4 commits into from
Oct 18, 2024

Conversation

teor2345
Copy link
Contributor

This PR adds an initial object fetching RPC as a separate crate. Having a separate crate allows RPC clients to depend on the RPC crate, rather than the whole gateway binary.

This PR is independent of the gateway binary and gateway DSN PRs.
It will be integrated into the gateway binary in an upcoming PR.

Code contributor checklist:

@teor2345 teor2345 added the enhancement New feature or request label Oct 17, 2024
@teor2345 teor2345 self-assigned this Oct 17, 2024
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered making subspace-gateway both binary and library like farmer is?

@teor2345
Copy link
Contributor Author

Have you considered making subspace-gateway both binary and library like farmer is?

That’s possible, but I think it’s a decision we can make later.

A Rust RPC client would just want to pull in the RPC definitions in this subspace-gateway-rpc crate, and its minimal dependencies. (And if that’s still too much, we can add a feature later to drop the dependency on the object fetcher and its crate.)

If we make subspace-gateway into a binary and library, then it could be used to launch a DSN connection, create the object fetcher, and then launch the RPC server in this crate. Which is a lot more code and dependencies.

@teor2345 teor2345 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit c828fc1 Oct 18, 2024
10 checks passed
@teor2345 teor2345 deleted the gateway-rpc branch October 18, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants