Add DSN client to subspace-gateway binary #3137
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
That makes sense. Edit: It was easier just to implement the RPC client. |
|
Alright, that should work as expected. I'll go rebase the RPC PR now. |
| impl RpcNodeClient { | ||
| /// Create a new instance of [`NodeClient`]. | ||
| pub async fn new(url: &str) -> Result<Self, JsonError> { | ||
| let client = Arc::new(WsClientBuilder::default().build(url).await?); | ||
| Ok(Self { client }) | ||
| } | ||
| } |
There was a problem hiding this comment.
This is fine for now, but it is a hack. I think we'll need a separate RPC for these purposes.
| /// Configuration for network stack | ||
| #[derive(Debug, Parser)] | ||
| pub(crate) struct NetworkArgs { | ||
| /// WebSocket RPC URL of the Subspace node to connect to. |
There was a problem hiding this comment.
listen-on is always helpful for local debugging as well as for setting up some cloud infrastructure. I'd add this parameter.
This PR adds a DSN client implementation to the
subspace-gatewaybinary.Code contributor checklist: