Add CheckHistorySeeder signed extension to prevent feeless and invalid remarks
#3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dastansam
requested review from
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
dastansam
commented
Sep 27, 2024
| let who = ensure_signed(origin.clone())?; | ||
|
|
||
| ensure!( | ||
| Some(who.clone()) == Self::history_seeder(), |
There was a problem hiding this comment.
not sure if I should still leave the validation here?
nazar-pc
approved these changes
Sep 28, 2024
| let who = ensure_signed(origin.clone())?; | ||
|
|
||
| ensure!( | ||
| Some(who.clone()) == Self::history_seeder(), |
vanhauser-thc
added
audited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code contributor checklist: