Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: https://forum.autonomys.xyz/t/farmer-equivocation-is-problematic/3063?u=nazar-pc
Changes that should be accurately audited are in
pallet-subspace
'slib.rs
andtests.rs
. Removal of block list in the runtime changes handling of rewards a bit and I had to update the test and implementation of vote checking to make sure we don't allow farmer to reuse the same solution twice. In particular entries are no longer removed from current block author info and current block voters, instead reward address became optional.Client-side code still checks equivocation, but doesn't handle it in any meaningful way yet since we do not have a spec for replacement implementation.
Code contributor checklist: