Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic equivocation #3072

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

nazar-pc
Copy link
Member

Background: https://forum.autonomys.xyz/t/farmer-equivocation-is-problematic/3063?u=nazar-pc

Changes that should be accurately audited are in pallet-subspace's lib.rs and tests.rs. Removal of block list in the runtime changes handling of rewards a bit and I had to update the test and implementation of vote checking to make sure we don't allow farmer to reuse the same solution twice. In particular entries are no longer removed from current block author info and current block voters, instead reward address became optional.

Client-side code still checks equivocation, but doesn't handle it in any meaningful way yet since we do not have a spec for replacement implementation.

Code contributor checklist:

@nazar-pc nazar-pc added the need to audit This change needs to be audited label Sep 27, 2024
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this makes sense to me, but I'd like someone else to double-check before it merges.

@nazar-pc nazar-pc added this pull request to the merge queue Oct 1, 2024
@nazar-pc
Copy link
Member Author

nazar-pc commented Oct 1, 2024

Adding to merge queue, but would still prefer more eyes on this if possible

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@nazar-pc nazar-pc added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 5ce067b Oct 1, 2024
11 checks passed
@nazar-pc nazar-pc deleted the remove-problematic-equivocation branch October 1, 2024 14:22
@vanhauser-thc vanhauser-thc added audited This change was audited and removed audited This change was audited labels Oct 7, 2024
@vanhauser-thc vanhauser-thc added audited This change was audited and removed need to audit This change needs to be audited labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audited This change was audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants