Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3h compatibility code #3069

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Remove 3h compatibility code #3069

merged 7 commits into from
Sep 30, 2024

Conversation

NingLin-P
Copy link
Member

close #2936

This PR finishes all the remaining items in #2936.

Code contributor checklist:

@@ -191,8 +191,7 @@ pub struct Operator<Balance, Share, DomainBlockNumber> {
/// The status of the operator, it may be stale due to the `OperatorStatus::PendingSlash` is
/// not assigned to this field directly, thus MUST use the `status()` method to query the status
/// instead.
/// TODO: update the filed to `_status` to avoid accidental access in next network reset
status: OperatorStatus<DomainBlockNumber>,
_status: OperatorStatus<DomainBlockNumber>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the name should be something else entirely? _ has the purpose of not triggering unused field lints. Not sure why it needs to be renamed if it is hidden in the first place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to emphasize this field should not be queried directly. Yeah, perhaps the comment and private field would be enough, I will rename it back to status or it would be great if you have other suggestions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking something like partial_status or preliminary_status or something similar, what makes sense in this context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! renamed to partial_status.

@teor2345
Copy link
Contributor

Test hang on Linux:

SLOW [>21000.000s] domain-client-operator tests::test_xdm_between_domains_should_work

https://github.com/autonomys/subspace/actions/runs/11055943073/job/30716305690?pr=3069#step:12:1811

Since this PR modifies domains code, I'm going to re-run the tests, but disable automatic merging until we've checked that it isn't making the tests fail more often.

@teor2345
Copy link
Contributor

Since this PR modifies domains code, I'm going to re-run the tests, but disable automatic merging until we've checked that it isn't making the tests fail more often.

Seems fine, I've re-run the tests again to be sure, and re-enabled auto merge.

@teor2345 teor2345 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 510da22 Sep 30, 2024
9 checks passed
@teor2345 teor2345 deleted the remove-3h-compatibility-code branch September 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up gemini-3h compatibility code
3 participants