Make Blake3Hash always encode as Hex in JSON #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
NingLin-P,
nazar-pc,
rg3l3dr and
shamil-gadelshin
as code owners
teor2345
commented
Sep 23, 2024
nazar-pc
reviewed
Sep 23, 2024
crates/subspace-farmer/src/bin/subspace-farmer/commands/benchmark.rs
Outdated
Show resolved
Hide resolved
crates/subspace-networking/src/behavior/persistent_parameters.rs
Outdated
Show resolved
Hide resolved
teor2345
commented
Sep 23, 2024
crates/subspace-farmer/src/bin/subspace-farmer/commands/benchmark.rs
Outdated
Show resolved
Hide resolved
teor2345
force-pushed
the
blake3-hash-hex
branch
from
b1b069c
to
6dc7222
Compare
teor2345
commented
Sep 24, 2024
nazar-pc
reviewed
Sep 25, 2024
teor2345
force-pushed
the
blake3-hash-hex
branch
from
6dc7222
to
d22f20d
Compare
teor2345
force-pushed
the
blake3-hash-hex
branch
from
d22f20d
to
7e917a3
Compare
|
I also removed |
nazar-pc
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure
Blake3Hashis always hex-encoded in JSON and debug contexts.It replaces the type alias to
[u8; 32]with a wrapper type, with appropriate trait impls and methods.This is slightly tricky due to Rust's trait coherence rules: arrays and slices are always foreign types.I'm happy to add or change trait impls to reduce the other code changes, but I've tried a lot of alternatives already. So significant changes might be better as a PR on top of this one.
Code contributor checklist: