Switch from async-lock
to tokio
primitives
#3021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that smol-rs/async-lock#91 not only affects RwLock, but also
Mutex
and possibly other primitives (we usedSemaphore
too in some case). So I decided to move away from it completely (though I did like API ofasync-lock
more).We still use
async-lock
in our fork of Substrate for parallel block verification implementation, I'll take care of it when we update Substrate again (should be soon, they're polishing September's release at the moment).Code contributor checklist: