Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from async-lock to tokio primitives #3021

Closed
wants to merge 1 commit into from

Conversation

nazar-pc
Copy link
Member

I discovered that smol-rs/async-lock#91 not only affects RwLock, but also Mutex and possibly other primitives (we used Semaphore too in some case). So I decided to move away from it completely (though I did like API of async-lock more).

We still use async-lock in our fork of Substrate for parallel block verification implementation, I'll take care of it when we update Substrate again (should be soon, they're polishing September's release at the moment).

Code contributor checklist:

@nazar-pc
Copy link
Member Author

Apparently this doesn't fix the issue fully either 🤔

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly straightforward, do you think it’s Substrate causing the remaining issues?

@nazar-pc
Copy link
Member Author

No, the issue is on the farmer, we have zero Substrate dependencies used there.

It is possible that the issue is actually in event-listener, which async-lock is based on and what we use directly in farmer too. See linked issue and links that follow from there.

@nazar-pc
Copy link
Member Author

Fix for underlying issue was merged in #3041, this doesn't fix anything

@nazar-pc nazar-pc closed this Sep 20, 2024
@nazar-pc nazar-pc deleted the switch-async-lock-to-tokio branch September 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants