Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history seeding pallet #3006

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add history seeding pallet #3006

merged 2 commits into from
Sep 16, 2024

Conversation

dastansam
Copy link
Contributor

@dastansam dastansam commented Sep 5, 2024 •
edited
Loading

The history seeding pallet allows an authorized account to add remarks to the blockchain, which can be used to seed historical data or important information into the chain's history. The authorized account for seeding can be set by root.

Code contributor checklist:

cc @dariolina

teor2345
teor2345 reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I’d like someone else to double-check before merging.

(I’m writing the mapping and retrieval parts of this feature 🙂)

dariolina
dariolina reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@dariolina dariolina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the history_seeder be an argument to the spec builder? Such that one can specify a different key from sudo

@dariolina dariolina added the need to audit This change needs to be audited label Sep 9, 2024
nazar-pc
nazar-pc reviewed Sep 10, 2024
View reviewed changes
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
dariolina
dariolina previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@dariolina dariolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. HBY @nazar-pc ?

nazar-pc
nazar-pc reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, just a few nits that do not impact the operation

crates/pallet-history-seeding/src/tests.rs Outdated Show resolved Hide resolved
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-history-seeding/src/lib.rs Outdated Show resolved Hide resolved
crates/subspace-runtime/src/lib.rs Outdated Show resolved Hide resolved
crates/subspace-node/src/chain_spec.rs Show resolved Hide resolved
@dastansam dastansam added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 62a015d Sep 16, 2024
11 checks passed
@dastansam dastansam deleted the history-seeding branch September 16, 2024 06:16
@vanhauser-thc vanhauser-thc added audited This change was audited and removed need to audit This change needs to be audited labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

@NingLin-P NingLin-P Awaiting requested review from NingLin-P NingLin-P is a code owner

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

@teor2345 teor2345 Awaiting requested review from teor2345

@dariolina dariolina Awaiting requested review from dariolina

Assignees
No one assigned
Labels
audited This change was audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dastansam @nazar-pc @teor2345 @dariolina @vanhauser-thc