Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmer cleanups #2745

Merged
merged 4 commits into from
May 8, 2024
Merged

Farmer cleanups #2745

merged 4 commits into from
May 8, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented May 7, 2024

A few things extracted from local branch.

Plotter refactoring is the same code as before, just the way semaphore is acquired is different in try_plot_sector.

Not waiting for plotted pieces is important because in farming cluster case it will be re-initialized many times as farms come and go, which wasn't a concern previously. It is still rare, so try_read() will succeed in most cases. More sophisticated approach would be to wait until some timeout, someone is free to implement that if they care about it enough.

Code contributor checklist:

@nazar-pc nazar-pc added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit a2206ad May 8, 2024
9 checks passed
@nazar-pc nazar-pc deleted the farmer-cleanups branch May 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants