Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things extracted from local branch.
Plotter refactoring is the same code as before, just the way semaphore is acquired is different in
try_plot_sector
.Not waiting for plotted pieces is important because in farming cluster case it will be re-initialized many times as farms come and go, which wasn't a concern previously. It is still rare, so
try_read()
will succeed in most cases. More sophisticated approach would be to wait until some timeout, someone is free to implement that if they care about it enough.Code contributor checklist: