Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting metadata refactoring #2743

Merged
merged 2 commits into from
May 7, 2024
Merged

Plotting metadata refactoring #2743

merged 2 commits into from
May 7, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented May 6, 2024

Two things changed here:

  • sector metadata was sent twice unnecessarily before in the plotting result, so encoded duplicate was removed
  • plotted sector as a whole was in the plotting progress notification, which was a problem if we were sending it across the network due to both large allocation necessary and awkwarness with data structure encoding that doesn't fit into NATS message size

With these changes implementation of farming cluster and similar use cases will be much easier and more memory-efficient.

Code contributor checklist:

@nazar-pc nazar-pc added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit f8bf280 May 7, 2024
9 checks passed
@nazar-pc nazar-pc deleted the plotting-metadata-refactoring branch May 7, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants