update actions cache and enable key restore #2055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix paths for windows
nazar-pc
requested changes
Oct 5, 2023
Comment on lines
+52
to
+53
| ${{ runner.os == 'Windows' && format('{0}/.cargo/registry', env.USERPROFILE) || '~/.cargo/registry' }} | ||
| ${{ runner.os == 'Windows' && format('{0}/.cargo/git', env.USERPROFILE) || '~/.cargo/git' }} |
There was a problem hiding this comment.
Are you really sure we need all this mess? I'm suspecting it worked fine the way it was.
| key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-cargo-${{ env.cache-name }}- | ||
| ${{ runner.os }}-cargo- |
There was a problem hiding this comment.
Generic ${{ runner.os }}-cargo- is good, but ${{ runner.os }}-cargo-${{ env.cache-name }}- will not be helpful here since we will never have anything in cache that matches such a key.
Restore keys are only used for matching during retrieval.
DaMandal0rian
commented
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR expands on #2043 and uses key restore based on github docs and fixes paths for windows. It also adds the upgrades the actions package for all jobs.
Code contributor checklist: