Update Rust toolchain

Dockerfile-bootstrap-node

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-bootstrap-node.aarch64

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-farmer

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-farmer.aarch64

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-node

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-node.aarch64

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

Dockerfile-runtime

@@ -1,6 +1,6 @@
 FROM ubuntu:20.04
 
-ARG RUSTC_VERSION=nightly-2024-08-01
+ARG RUSTC_VERSION=nightly-2024-09-26
 ARG PROFILE=production
 ARG RUSTFLAGS
 # Workaround for https://github.com/rust-lang/cargo/issues/10583

crates/pallet-domains/src/lib.rs

@@ -624,8 +624,9 @@ mod pallet {
     pub(super) type NewAddedHeadReceipt<T: Config> =
         StorageMap<_, Identity, DomainId, T::DomainHash, OptionQuery>;
 
-    /// The consensus block hash used to verify ER,
-    /// only store the consensus block hash for a domain
+    /// Map of consensus block hashes.
+    ///
+    /// The consensus block hash used to verify ER, only store the consensus block hash for a domain
     /// if that consensus block contains bundle of the domain, the hash will be pruned when the ER
     /// that point to the consensus block is pruned.
     ///
@@ -724,13 +725,15 @@ mod pallet {
     pub type DomainRuntimeUpgrades<T> = StorageValue<_, Vec<RuntimeId>, ValueQuery>;
 
     /// Temporary storage to hold the sudo calls meant for the Domains.
+    ///
     /// Storage is cleared when there are any successful bundles in the next block.
     /// Only one sudo call is allowed per domain per consensus block.
     #[pallet::storage]
     pub type DomainSudoCalls<T: Config> =
         StorageMap<_, Identity, DomainId, DomainSudoCall, ValueQuery>;
 
     /// Storage that hold a list of all frozen domains.
+    ///
     /// A frozen domain does not accept the bundles but does accept a fraud proof.
     #[pallet::storage]
     pub type FrozenDomains<T> = StorageValue<_, BTreeSet<DomainId>, ValueQuery>;

crates/pallet-subspace/src/equivocation.rs

@@ -48,10 +48,11 @@ use subspace_core_primitives::PublicKey;
 
 use crate::{Call, Config, Pallet};
 
-/// A trait with utility methods for handling equivocation reports in Subspace. The trait provides
-/// methods for reporting an offence triggered by a valid equivocation report, checking the current
-/// block author (to declare as the reporter), and also for creating and submitting equivocation
-/// report extrinsics (useful only in offchain context).
+/// A trait with utility methods for handling equivocation reports in Subspace.
+///
+/// The trait provides methods for reporting an offence triggered by a valid equivocation report,
+/// checking the current block author (to declare as the reporter), and also for creating and
+/// submitting equivocation report extrinsics (useful only in offchain context).
 pub trait HandleEquivocation<T: Config> {
     /// The longevity, in blocks, that the equivocation report is valid for. When using the staking
     /// pallet this should be equal to the bonding duration (in blocks, not eras).
@@ -87,9 +88,10 @@ impl<T: Config> HandleEquivocation<T> for () {
     }
 }
 
-/// Generic equivocation handler. This type implements `HandleEquivocation`
-/// using existing subsystems that are part of frame (type bounds described
-/// below) and will dispatch to them directly, it's only purpose is to wire all
+/// Generic equivocation handler.
+///
+/// This type implements `HandleEquivocation` using existing subsystems that are part of frame (type
+/// bounds described below) and will dispatch to them directly, it's only purpose is to wire all
 /// subsystems together.
 pub struct EquivocationHandler<R, L> {
     _phantom: sp_std::marker::PhantomData<(R, L)>,

crates/sc-consensus-subspace/src/archiver.rs

@@ -736,8 +736,10 @@ fn finalize_block<Block, Backend, Client>(
     });
 }
 
-/// Create an archiver task that will listen for importing blocks and archive blocks at `K` depth,
-/// producing pieces and segment headers (segment headers are then added back to the blockchain as
+/// Create an archiver task.
+///
+/// Archiver task will listen for importing blocks and archive blocks at `K` depth, producing pieces
+/// and segment headers (segment headers are then added back to the blockchain as
 /// `store_segment_header` extrinsic).
 ///
 /// NOTE: Archiver is doing blocking operations and must run in a dedicated task.

crates/sc-consensus-subspace/src/slot_worker.rs

@@ -79,6 +79,8 @@ use tracing::{debug, error, info, warn};
 /// Large enough size for any practical purposes, there shouldn't be even this many solutions.
 const PENDING_SOLUTIONS_CHANNEL_CAPACITY: usize = 10;
 
+/// Subspace sync oracle.
+///
 /// Subspace sync oracle that takes into account force authoring flag, allowing to bootstrap
 /// Subspace network from scratch due to our fork of Substrate where sync state of nodes depends on
 /// connected nodes (none of which will be synced initially). It also accounts for DSN sync, when

crates/sc-domains/src/lib.rs

@@ -160,9 +160,10 @@ where
     }
 }
 
-/// Generate MMR proof for the block `to_prove` in the current best fork. The returned proof
-/// can be later used to verify stateless (without query offchain MMR leaf) and extract the state
-/// root at `to_prove`.
+/// Generate MMR proof for the block `to_prove` in the current best fork.
+///
+/// The returned proof can be later used to verify stateless (without query offchain MMR leaf) and
+/// extract the state root at `to_prove`.
 pub fn generate_mmr_proof<CClient, CBlock>(
     consensus_client: &Arc<CClient>,
     to_prove: NumberFor<CBlock>,

crates/sc-subspace-block-relay/src/utils.rs

@@ -15,10 +15,10 @@ use substrate_prometheus_endpoint::{
 
 type NetworkRequestService = Arc<dyn NetworkRequest + Send + Sync + 'static>;
 
-/// Wrapper to work around the circular dependency in substrate:
-/// `build_network()` requires the block relay to be passed in,
-/// which internally needs the network handle. `set()` is
-/// used to fill in the network after the network is created.
+/// Wrapper to work around the circular dependency in substrate.
+///
+/// `build_network()` requires the block relay to be passed in, which internally needs the network
+/// handle. `set()` is used to fill in the network after the network is created.
 pub struct NetworkWrapper {
     network: Mutex<Option<NetworkRequestService>>,
 }

crates/sp-domains-fraud-proof/src/execution_prover.rs

@@ -1,7 +1,8 @@
 //! This module provides the feature of generating and verifying the execution proof used in
-//! the Subspace fraud proof mechanism. The execution is more fine-grained than the entire
-//! block execution, block execution hooks (`initialize_block` and `finalize_block`) and any
-//! specific extrinsic execution are supported.
+//! the Subspace fraud proof mechanism.
+//!
+//! The execution is more fine-grained than the entire block execution, block execution hooks
+//! (`initialize_block` and `finalize_block`) and any specific extrinsic execution are supported.
 
 use crate::fraud_proof::ExecutionPhase;
 use codec::Codec;

crates/sp-domains-fraud-proof/src/tests.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use crate::test_ethereum_tx::{
     EIP1559UnsignedTransaction, EIP2930UnsignedTransaction, LegacyUnsignedTransaction,
 };

crates/sp-domains/src/lib.rs

@@ -1408,6 +1408,7 @@ impl DomainAllowlistUpdates {
 }
 
 /// Domain Sudo runtime call.
+///
 /// This structure exists because we need to generate a storage proof for FP
 /// and Storage shouldn't be None. So each domain must always hold this value even if
 /// there is an empty runtime call inside

crates/sp-domains/src/valued_trie.rs

@@ -29,6 +29,7 @@ type ArrayNode<T> = [CacheNode<TrieHash<T>>; 16];
 
 /// This is a modified version of trie root that takes trie node values instead of deriving from
 /// the actual data. Taken from `trie-db` as is.
+///
 /// Note: This is an opportunity to push this change upstream but I'm not sure how to present these
 /// changes yet. Need to be discussed further.
 pub fn valued_ordered_trie_root<Layout>(

crates/subspace-core-primitives/src/lib.rs

@@ -23,7 +23,7 @@
     const_option,
     const_trait_impl,
     const_try,
-    new_uninit,
+    new_zeroed_alloc,
     portable_simd,
     step_trait
 )]

crates/subspace-core-primitives/src/pieces.rs

@@ -1056,9 +1056,7 @@ impl AsMut<[u8]> for CowBytes {
 
                 bytes.as_mut()
             }
-            CowBytes::Owned(bytes) => {
-                return bytes.as_mut();
-            }
+            CowBytes::Owned(bytes) => bytes.as_mut(),
         }
     }
 }

crates/subspace-farmer-components/src/lib.rs

@@ -9,7 +9,7 @@
     int_roundings,
     iter_collect_into,
     never_type,
-    new_uninit,
+    new_zeroed_alloc,
     portable_simd,
     try_blocks
 )]

crates/subspace-farmer-components/src/reading.rs

@@ -162,10 +162,10 @@ where
     S: ReadAtSync,
     A: ReadAtAsync,
 {
-    // TODO: Should have been just `::new()`, but https://github.com/rust-lang/rust/issues/53827
-    // SAFETY: Data structure filled with zeroes is a valid invariant
-    let mut record_chunks =
-        unsafe { Box::<[Option<Scalar>; Record::NUM_S_BUCKETS]>::new_zeroed().assume_init() };
+    let mut record_chunks = Box::<[Option<Scalar>; Record::NUM_S_BUCKETS]>::try_from(
+        vec![None::<Scalar>; Record::NUM_S_BUCKETS].into_boxed_slice(),
+    )
+    .expect("Correct size; qed");
 
     let read_chunks_inputs = record_chunks
         .par_iter_mut()

crates/subspace-farmer-components/src/sector.rs

@@ -265,6 +265,8 @@ pub enum SectorContentsMapIterationError {
     },
 }
 
+/// Map of sector contents.
+///
 /// Abstraction on top of bitfields that allow making sense of sector contents that contains both
 /// encoded (meaning erasure coded and encoded with existing PoSpace quality) and unencoded chunks
 /// (just erasure coded) used at the same time both in records (before writing to plot) and

crates/subspace-farmer/src/bin/subspace-farmer/main.rs

@@ -1,3 +1,8 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
 #![feature(
     const_option,
     duration_constructors,

crates/subspace-farmer/src/cluster/cache.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 //! Farming cluster cache
 //!
 //! Cache is responsible for caching pieces within allocated space to accelerate plotting and serve

crates/subspace-farmer/src/cluster/farmer.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 //! Farming cluster farmer
 //!
 //! Farmer is responsible for maintaining farms, doing audits and generating proofs when solution is

crates/subspace-farmer/src/disk_piece_cache.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 //! Disk piece cache implementation
 
 mod metrics;

crates/subspace-farmer/src/farm.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 //! Abstract farm API
 //!
 //! This module provides a bunch of traits and simple data structures that serve as a layer of

crates/subspace-farmer/src/farmer_cache/tests.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use crate::disk_piece_cache::DiskPieceCache;
 use crate::farmer_cache::{decode_piece_index_from_record_key, FarmerCache};
 use crate::node_client::{Error, NodeClient};

crates/subspace-farmer/src/single_disk_farm/piece_cache.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 //! Cache implementation specific to single disk farm
 
 use crate::disk_piece_cache::DiskPieceCache;

crates/subspace-farmer/src/single_disk_farm/plot_cache/tests.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use crate::farm::MaybePieceStoredResult;
 use crate::single_disk_farm::plot_cache::DiskPlotCache;
 #[cfg(windows)]

crates/subspace-farmer/src/single_disk_farm/plotted_sectors.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    elided_named_lifetimes,
+    reason = "https://github.com/dtolnay/async-trait/issues/279"
+)]
+
 use crate::farm::{FarmError, PlottedSectors};
 use async_lock::RwLock as AsyncRwLock;
 use async_trait::async_trait;

crates/subspace-farmer/src/single_disk_farm/plotting.rs

@@ -34,8 +34,6 @@ use tokio::task;
 use tracing::{debug, info, info_span, trace, warn, Instrument};
 
 const FARMER_APP_INFO_RETRY_INTERVAL: Duration = Duration::from_millis(500);
-/// Size of the cache of archived segments for the purposes of faster sector expiration checks.
-
 const PLOTTING_RETRY_DELAY: Duration = Duration::from_secs(1);
 
 pub(super) struct SectorToPlot {

crates/subspace-farmer/src/utils.rs

@@ -518,9 +518,12 @@ fn create_plotting_thread_pool_manager_thread_pool_pair(
         .build()
 }
 
-/// Creates thread pool pairs for each of CPU core set pair with number of plotting and replotting threads corresponding
-/// to number of cores in each set and pins threads to all of those CPU cores (each thread to all cors in a set, not
-/// thread per core). Each thread will also have Tokio context available.
+/// Create thread pools manager.
+///
+/// Creates thread pool pairs for each of CPU core set pair with number of plotting and replotting
+/// threads corresponding to number of cores in each set and pins threads to all of those CPU cores
+/// (each thread to all cors in a set, not thread per core). Each thread will also have Tokio
+/// context available.
 ///
 /// The easiest way to obtain CPUs is using [`all_cpu_cores`], but [`thread_pool_core_indices`] in case
 /// support for user customizations is desired. They will then have to be composed into pairs for this function.

crates/subspace-farmer/src/utils/tests.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use crate::utils::{
     parse_cpu_cores_sets, run_future_in_dedicated_thread, thread_pool_core_indices_internal,
     CpuCoreSet,

crates/subspace-networking/examples/benchmark.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use backoff::future::retry;
 use backoff::ExponentialBackoff;
 use clap::Parser;

crates/subspace-networking/examples/get-peers.rs

@@ -1,3 +1,9 @@
+// TODO: Remove
+#![allow(
+    clippy::needless_return,
+    reason = "https://github.com/rust-lang/rust-clippy/issues/13458"
+)]
+
 use futures::channel::oneshot;
 use futures::StreamExt;
 use libp2p::multiaddr::Protocol;