Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update networks #387

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Update networks #387

merged 3 commits into from
Jan 15, 2025

Conversation

DaMandal0rian
Copy link
Member

@DaMandal0rian DaMandal0rian commented Jan 15, 2025

PR Type

enhancement


Description

  • Updated Docker tags for mainnet configurations to mainnet-2025-jan-14.

  • Updated Docker tags for taurus configurations to taurus-2025-jan-07.

  • Ensured consistency in deployment configurations across multiple modules.


Changes walkthrough 📝

Relevant files
Enhancement
main.tf
Update Docker tags for mainnet configurations                       

resources/mainnet/main.tf

  • Updated Docker tags for all mainnet configurations to
    mainnet-2025-jan-14.
  • Ensured consistent versioning across various node configurations.
  • +8/-8     
    main.tf
    Update Docker tags for taurus configurations                         

    resources/taurus/main.tf

  • Updated Docker tags for all taurus configurations to
    taurus-2025-jan-07.
  • Ensured consistent versioning across various node configurations.
  • +8/-8     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consistency Check

    Ensure that the updated docker-tag values for mainnet configurations are consistent across all modules and align with the intended deployment strategy.

      docker-tag         = "mainnet-2025-jan-14"
      reserved-only      = false
      prune              = false
      genesis-hash       = "b256e3ca1d3ef43c1e52799df670aa307671b9e468c500def1f5b6b77173b5d4"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-evm-config = {
      instance-type      = var.instance_type["evm_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["evm_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      reserved-only      = false
      prune              = false
      genesis-hash       = "b256e3ca1d3ef43c1e52799df670aa307671b9e468c500def1f5b6b77173b5d4"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-autoid-config = {
      instance-type      = var.instance_type["autoid_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["autoid_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      reserved-only      = false
      prune              = false
      genesis-hash       = "b256e3ca1d3ef43c1e52799df670aa307671b9e468c500def1f5b6b77173b5d4"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-indexer-node-config = {
      instance-type      = var.instance_type["rpc-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      domain-prefix      = "rpc-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    nova-indexer-node-config = {
      instance-type      = var.instance_type["nova-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["nova-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      domain-prefix      = "auto-evm-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-node-config = {
      instance-type      = var.instance_type["rpc"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      domain-prefix      = "rpc"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    domain-node-config = {
      instance-type      = var.instance_type["domain"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["domain"]
      docker-org         = "autonomys"
      docker-tag         = "mainnet-2025-jan-14"
      domain-prefix      = ["auto-evm", "autoid"]
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    farmer-node-config = {
      instance-type          = var.instance_type["farmer"]
      deployment-version     = 0
      regions                = var.aws_region
      instance-count         = var.instance_count["farmer"]
      docker-org             = "autonomys"
      docker-tag             = "mainnet-2025-jan-14"
    Consistency Check

    Verify that the updated docker-tag values for taurus configurations are consistent across all modules and align with the intended deployment strategy.

      docker-tag         = "taurus-2025-jan-07"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-evm-config = {
      instance-type      = var.instance_type["evm_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["evm_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    bootstrap-node-autoid-config = {
      instance-type      = var.instance_type["autoid_bootstrap"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["autoid_bootstrap"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      reserved-only      = false
      prune              = false
      genesis-hash       = "295aeafca762a304d92ee1505548695091f6082d3f0aa4d092ac3cd6397a6c5e"
      dsn-listen-port    = 30533
      node-dsn-port      = 30433
      operator-port      = 30334
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-indexer-node-config = {
      instance-type      = var.instance_type["rpc-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      domain-prefix      = "rpc-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    nova-indexer-node-config = {
      instance-type      = var.instance_type["nova-indexer"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["nova-indexer"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      domain-prefix      = "auto-evm-indexer"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    rpc-node-config = {
      instance-type      = var.instance_type["rpc"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["rpc"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      domain-prefix      = "rpc"
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    domain-node-config = {
      instance-type      = var.instance_type["domain"]
      deployment-version = 0
      regions            = var.aws_region
      instance-count     = var.instance_count["domain"]
      docker-org         = "autonomys"
      docker-tag         = "taurus-2025-jan-07"
      domain-prefix      = ["auto-evm", "autoid"]
      reserved-only      = false
      prune              = false
      node-dsn-port      = 30433
      enable-domains     = true
      domain-id          = var.domain_id
      domain-labels      = var.domain_labels
      disk-volume-size   = var.disk_volume_size
      disk-volume-type   = var.disk_volume_type
    }
    
    farmer-node-config = {
      instance-type          = var.instance_type["farmer"]
      deployment-version     = 0
      regions                = var.aws_region
      instance-count         = var.instance_count["farmer"]
      docker-org             = "autonomys"
      docker-tag             = "taurus-2025-jan-07"

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Verify compatibility of the updated docker-tag values with existing configurations and dependencies

    Ensure that the new docker-tag values are tested and verified to be compatible with
    the existing configurations and dependencies to avoid runtime issues.

    resources/mainnet/main.tf [13]

    -docker-tag         = "mainnet-2025-jan-14"
    +docker-tag         = "mainnet-2025-jan-14" # Ensure compatibility with existing configurations
    Suggestion importance[1-10]: 7

    Why: The suggestion to verify compatibility of the updated docker-tag values with existing configurations is valid and important to ensure smooth deployment and runtime. However, the suggestion is not actionable in code and relies on external verification, which slightly reduces its impact.

    7
    Validate that the updated docker-tag values align with the intended deployment version and avoid regressions

    Confirm that the updated docker-tag values align with the intended deployment
    version and do not introduce unexpected changes or regressions.

    resources/taurus/main.tf [13]

    -docker-tag         = "taurus-2025-jan-07"
    +docker-tag         = "taurus-2025-jan-07" # Confirm alignment with deployment version
    Suggestion importance[1-10]: 7

    Why: The suggestion to confirm alignment of the updated docker-tag values with the intended deployment version is relevant and helps prevent potential regressions. However, like the first suggestion, it is not directly actionable in code and depends on external validation, which slightly reduces its impact.

    7

    @DaMandal0rian DaMandal0rian merged commit a44eb94 into main Jan 15, 2025
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the update-networks branch January 15, 2025 17:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    1 participant