- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compileOnly dependencies are not visible to the test compile classpath. #1362
Conversation
fun isVisibleToTestSource(usages: Set<Usage>, declarations: Set<Declaration>): Boolean { | ||
return usages.reallyAll { usage -> | ||
VISIBLE_TO_TEST_SOURCE.any { it == usage.bucket } | ||
&& declarations.any { API.matches(it) || IMPL.matches(it) } | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix.
fun isVisibleToTestSource(usages: Set<Usage>, declarations: Set<Declaration>): Boolean { | ||
return usages.reallyAll { usage -> | ||
VISIBLE_TO_TEST_SOURCE.any { it == usage.bucket } | ||
&& declarations.any { API.matches(it) || IMPL.matches(it) } | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix.
val isMainVisibleDownstream = mainUsages.reallyAll { usage -> | ||
Bucket.VISIBLE_TO_TEST_SOURCE.any { it == usage.bucket } | ||
} | ||
val isMainVisibleDownstream = Bucket.isVisibleToTestSource(mainUsages, mainDeclarations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix.
dac18a5
to
3a3fdb8
Compare
❌ Test workflow failed:
|
…sspath.
3a3fdb8
to
f32518b
Compare
No description provided.