Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to new, non-deprecated AGP APIs. Min AGP version now 8.0. #1092

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

autonomousapps
Copy link
Owner

@autonomousapps autonomousapps commented Dec 30, 2023

Ahead of migrating to non-deprecated APIs.

TODO:

  • Migrate usages for databinding and viewbinding.

Copy link

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/23f6ml4atfdeq
* TestKit check            : https://gradle.com/s/zkhs5el2akqh4
* JVM functional tests     : https://gradle.com/s/lmhqplwoxqt22
* Android functional tests : https://gradle.com/s/7cennw3l4hcju
* Root buildHealth         : 
* TestKit buildHealth      : 

Copy link

github-actions bot commented Jan 6, 2024

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/bod7cnny7wqiy
* TestKit check            : https://gradle.com/s/vfbaxwl5ct7du
* JVM functional tests     : https://gradle.com/s/yogph2zqvh5ny
* Android functional tests : https://gradle.com/s/wkbmi5vb6xzyk
* Root buildHealth         : 
* TestKit buildHealth      : 

How did this not break tests earlier? What weird caching is going on?
@autonomousapps autonomousapps force-pushed the trobalik.agp-api branch 2 times, most recently from 3fa66d0 to 5f3bd19 Compare January 8, 2024 03:11
Copy link

github-actions bot commented Jan 8, 2024

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/z72uburclzn4o
* TestKit check            : https://gradle.com/s/gamrax76vjini
* JVM functional tests     : https://gradle.com/s/kg2v3axq7rvi2
* Android functional tests : https://gradle.com/s/45w4fqpezofhe
* Root buildHealth         : 
* TestKit buildHealth      : 

Copy link

github-actions bot commented Jan 8, 2024

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/527x6ahmvxhea
* TestKit check            : https://gradle.com/s/jowgfhjtgepwq
* JVM functional tests     : https://gradle.com/s/d63n2yvcbnaeu
* Android functional tests : https://gradle.com/s/e4rox2riadl3w
* Root buildHealth         : 
* TestKit buildHealth      : 

Copy link

github-actions bot commented Jan 8, 2024

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/ky2dr27qd65s4
* TestKit check            : https://gradle.com/s/hmafwm35fg7aw
* JVM functional tests     : https://gradle.com/s/zuvivb67vphca
* Android functional tests : https://gradle.com/s/twbb2vduqpfsw
* Root buildHealth         : 
* TestKit buildHealth      : 

Copy link

github-actions bot commented Jan 8, 2024

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/lauzhvdfoizpo
* TestKit check            : https://gradle.com/s/ae4vih7ocf3mo
* JVM functional tests     : https://gradle.com/s/usksggtltleue
* Android functional tests : https://gradle.com/s/5srjm5do2nzmc
* Root buildHealth         : 
* TestKit buildHealth      : 

Comment on lines 88 to 93
// TODO(tsr): return just a single file?
override fun getManifestFiles(): Provider<Iterable<File>> {
return agpVariant.artifacts.get(SingleArtifact.MERGED_MANIFEST).map {
listOf(it.asFile)
}
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@autonomousapps autonomousapps marked this pull request as ready for review January 8, 2024 20:52
@autonomousapps autonomousapps changed the title chore: update AGP dependencies. feat: migrate to new, non-deprecated AGP APIs. Min AGP version now 8.0. Jan 8, 2024
@autonomousapps autonomousapps merged commit 58d9581 into main Jan 8, 2024
1 check passed
@autonomousapps autonomousapps deleted the trobalik.agp-api branch January 8, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant