-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to new, non-deprecated AGP APIs. Min AGP version now 8.0. #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Test workflow failed:
|
4f46583
to
f8a37a9
Compare
f8a37a9
to
61acf15
Compare
❌ Test workflow failed:
|
How did this not break tests earlier? What weird caching is going on?
3fa66d0
to
5f3bd19
Compare
❌ Test workflow failed:
|
❌ Test workflow failed:
|
❌ Test workflow failed:
|
❌ Test workflow failed:
|
autonomousapps
commented
Jan 8, 2024
Comment on lines
88
to
93
// TODO(tsr): return just a single file? | ||
override fun getManifestFiles(): Provider<Iterable<File>> { | ||
return agpVariant.artifacts.get(SingleArtifact.MERGED_MANIFEST).map { | ||
listOf(it.asFile) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
a3ac0ee
to
d308d1c
Compare
d308d1c
to
58d9581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahead of migrating to non-deprecated APIs.
TODO: