Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to hatch #598

Merged
merged 18 commits into from
Apr 21, 2024
Merged

migrate to hatch #598

merged 18 commits into from
Apr 21, 2024

Conversation

mikkokotila
Copy link
Contributor

@mikkokotila mikkokotila commented Apr 20, 2024

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through
the below items:

Sanity

  • I'm aware of the implications of the proposed changes
  • Code is PEP8
  • I'm making the PR to master
  • I've updated the versions based on Semantic Versioning
    • setup.py
    • talos/__init__.py
    • docs/index.html
    • docs/_coverpage.md

Docs

Tests

  • Changes have gone through actual use testing
  • All local tests have passed (run ./test.sh in /talos)
  • Tests have been updated to reflect the changes

@pep8speaks
Copy link

pep8speaks commented Apr 20, 2024

Hello @mikkokotila! Thanks for updating this PR.

Line 5:1: F401 '.scan.Scan.Scan' imported but unused
Line 6:1: F401 '.commands.analyze.Analyze' imported but unused
Line 7:1: F401 '.commands.analyze.Analyze as Reporting' imported but unused
Line 8:1: F401 '.commands.predict.Predict' imported but unused
Line 9:1: F401 '.commands.deploy.Deploy' imported but unused
Line 10:1: F401 '.commands.evaluate.Evaluate' imported but unused
Line 11:1: F401 '.commands.restore.Restore' imported but unused
Line 14:1: F401 '.utils' imported but unused
Line 16:1: F401 '.autom8' imported but unused
Line 17:1: F401 '.callbacks' imported but unused
Line 35:5: F821 undefined name 'commands'
Line 35:15: F821 undefined name 'scan'
Line 35:21: F821 undefined name 'model'
Line 35:28: F821 undefined name 'metrics'

Line 15:5: F811 redefinition of unused 'Adagrad' from line 14

Line 19:1: W293 blank line contains whitespace

Line 5:5: F403 'from tests.commands import *' used; unable to detect undefined names
Line 7:19: F405 'test_scan' may be undefined, or defined from star imports: tests.commands
Line 8:5: F405 'test_latest' may be undefined, or defined from star imports: tests.commands
Line 9:5: F405 'recover_best_model' may be undefined, or defined from star imports: tests.commands
Line 10:5: F405 'test_random_methods' may be undefined, or defined from star imports: tests.commands
Line 11:5: F405 'test_autom8' may be undefined, or defined from star imports: tests.commands
Line 12:5: F405 'test_templates' may be undefined, or defined from star imports: tests.commands
Line 12:21: W291 trailing whitespace
Line 13:5: F405 'test_analyze' may be undefined, or defined from star imports: tests.commands
Line 14:5: F405 'test_lr_normalizer' may be undefined, or defined from star imports: tests.commands
Line 15:5: F405 'test_predict' may be undefined, or defined from star imports: tests.commands
Line 16:5: F405 'test_reducers' may be undefined, or defined from star imports: tests.commands
Line 17:5: F405 'test_rest' may be undefined, or defined from star imports: tests.commands

Line 13:5: E265 block comment should start with '# '
Line 15:5: E265 block comment should start with '# '

Line 46:89: E501 line too long (89 > 88 characters)

Line 6:5: F401 'tensorflow as tf' imported but unused

Line 17:1: E302 expected 2 blank lines, found 1
Line 17:2: F821 undefined name 'profile'
Line 23:89: E501 line too long (107 > 88 characters)
Line 36:53: E127 continuation line over-indented for visual indent
Line 37:53: E127 continuation line over-indented for visual indent
Line 38:53: E127 continuation line over-indented for visual indent
Line 39:53: E127 continuation line over-indented for visual indent
Line 40:53: E127 continuation line over-indented for visual indent
Line 44:5: F841 local variable 'scan_object' is assigned to but never used
Line 51:1: W191 indentation contains tabs
Line 51:1: E101 indentation contains mixed spaces and tabs
Line 51:21: E128 continuation line under-indented for visual indent

Comment last updated at 2024-04-21 08:37:15 UTC

@mikkokotila mikkokotila merged commit 66e8540 into master Apr 21, 2024
8 checks passed
@mikkokotila mikkokotila deleted the migrate_to_hatch branch April 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants