-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Made CrossValTypes, HoldoutValTypes to have split functions directly #108
Open
nabenabe0928
wants to merge
12
commits into
automl:master
Choose a base branch
from
nabenabe0928:refactoring-base-dataset_splitting-functions_major-change
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+236
−309
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b803770
[refactor] Update the split functions to be able to call function dir…
nabenabe0928 4d901f9
[feat] Deprecate shuffle inside BaseDataset and enable only in split …
nabenabe0928 6c31f61
[fix] Fix flake8 and mypy issues
nabenabe0928 b7d3531
[fix] Fix mypy issues
nabenabe0928 eee3b1c
[fix] Fix mypy issues and modify the test accordingly
nabenabe0928 910e7d4
[fix] Fix most test cases
nabenabe0928 8c9b895
[fix] Bring back the data generator shuffle
nabenabe0928 93e6862
[fix] Fix the test value caused by putting back the shuffle generator
nabenabe0928 bef4323
[fix] Fix pytest errors
nabenabe0928 2d2ebb8
[refactor] Change files so that we can see the difference easier
nabenabe0928 8d90b85
[refactor] Gether kwargs for get splits for CV and Holdout
nabenabe0928 6ef981d
[fix] Fix a mypy issue
nabenabe0928 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[fix] Fix most test cases
commit 910e7d461402b965ea2ec688a5d7f89665dc3a6f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an example to use it directly?