Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for cache key errors #35

Merged
merged 4 commits into from
May 22, 2024
Merged

Better handling for cache key errors #35

merged 4 commits into from
May 22, 2024

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented May 16, 2024

When loading tokens from the .arcache fails, proactively delete the file, so that the user is forced to set-up the CLI again.

Also, remove grading_deadline logic.

Closes #23

To test:

  • Set up autolab CLI (in debug mode)
  • Try loading an assessment, make sure there no string_to_time parse fail! messages (previously caused by attempting to parse grading_deadline)
  • Ensure that .autolab/.arcache file exists in user home directory
  • Update crypto_key in app_credentials.h, and rebuild CLI
  • Try loading an assessment again, get error message
Screenshot 2024-05-15 at 22 17 45
  • Check that .autolab/.arcache file has been removed
  • Try loading an assessment again - no more error about load_tokens
Screenshot 2024-05-15 at 22 18 04

@damianhxy damianhxy marked this pull request as ready for review May 16, 2024 02:19
@damianhxy damianhxy requested a review from 20wildmanj May 16, 2024 02:19
Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

Walkthrough

The recent updates primarily enhance error handling and code consistency in the Autolab system. Key modifications include the removal of the grading_deadline field from the Assessment struct, improved exception handling with std::move and noexcept, and the introduction of a CryptoException class for better encryption error management. Additionally, file operations in the context manager now handle crypto exceptions, and the crypto module's error handling is refined to throw exceptions instead of exiting.

Changes

Files/Paths Change Summary
include/autolab/autolab.h Removed grading_deadline from Assessment, updated exception constructors and what methods, added CryptoException class.
lib/autolab/client.cpp Stopped assigning grading_deadline in assessment_from_json.
src/context_manager/context_manager.cpp Included autolab.h, added try-catch blocks for CryptoException in store_tokens and load_tokens.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Diagnose and describe cache key mismatch error (#23)

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 5f2aa4e and 0bb2dd2.
Files selected for processing (1)
  • src/context_manager/context_manager.cpp (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/context_manager/context_manager.cpp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that ignoring cache on crypto error works by recreating the error found with autolab V3 on AFS, setup now works without having to manually delete the cache. LGTM besides logging comment.

@damianhxy damianhxy added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 5c510f3 May 22, 2024
2 checks passed
@damianhxy damianhxy deleted the cache-key-error branch May 22, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Useless error when cache key does not match
2 participants