-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling for cache key errors #35
Conversation
WalkthroughWalkthroughThe recent updates primarily enhance error handling and code consistency in the Autolab system. Key modifications include the removal of the Changes
Assessment against linked issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that ignoring cache on crypto error works by recreating the error found with autolab V3 on AFS, setup now works without having to manually delete the cache. LGTM besides logging comment.
When loading tokens from the
.arcache
fails, proactively delete the file, so that the user is forced to set-up the CLI again.Also, remove
grading_deadline
logic.Closes #23
To test:
string_to_time parse fail!
messages (previously caused by attempting to parsegrading_deadline
).autolab/.arcache
file exists in user home directorycrypto_key
inapp_credentials.h
, and rebuild CLI.autolab/.arcache
file has been removedload_tokens