Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix] Fix the time series target, timestamp and id column issue for attach_job call #167

Merged
merged 12 commits into from
Jan 16, 2025

Conversation

tonyhoo
Copy link
Contributor

@tonyhoo tonyhoo commented Jan 10, 2025

Issue #165

Description of changes:

  • Fixed TimeSeriesCloudPredictor attach_job() functionality to properly restore id_column, timestamp_column and target_column attributes from training job metadata
  • Added predictor metadata serialization during fit() to store these attributes
  • Modified SageMakerFitJob to properly handle predictor_metadata in hyperparameters

The fix allows TimeSeriesCloudPredictor to work properly after attach_job() without manual attribute setting

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@suzhoum suzhoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a couple of minor comments.

@tonyhoo tonyhoo merged commit 9a1d727 into autogluon:master Jan 16, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants