Parameter data type validation is added. (#17)

autodesk-platform-services · Oct 12, 2023 · 7afb569 · 7afb569
1 parent 168173a
commit 7afb569
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/src/ConsoleConnector/Commands/AddParamCommand.cs b/src/ConsoleConnector/Commands/AddParamCommand.cs
@@ -42,6 +42,11 @@ public override Task<bool> Execute()
             var parameterName = this.GetOption<ParameterName>();
             var parameterValue = this.GetOption<ParameterValue>();
             var parameterValueType = this.GetOption<ParameterValueDataType>();
+            if (parameterValueType.IsValidDataType == false)
+            {
+                Console.WriteLine("Invalid data type. Please try Help command to get more details.");
+                return Task.FromResult(false);
+            }
             var exchangeData = ConsoleAppHelper.GetExchangeData(exchangeTitle.Value);
             if (exchangeData == null)
             {

diff --git a/src/ConsoleConnector/Commands/CreatePrimitiveGeometryCommand.cs b/src/ConsoleConnector/Commands/CreatePrimitiveGeometryCommand.cs
@@ -67,7 +67,7 @@ public override Task<bool> Execute()
             }
             else if (primitiveGeometryOption.Value == PrimitiveGeometryType.Polyline)
             {
-                element = ConsoleAppHelper.GetGeometryHelper().AddPolyline(revitExchangeData);
+                element = ConsoleAppHelper.GetGeometryHelper().AddPolyline(elementDataModel);
             }
             else
             {

diff --git a/src/ConsoleConnector/Commands/Options/ParameterValueDataType.cs b/src/ConsoleConnector/Commands/Options/ParameterValueDataType.cs
@@ -9,6 +9,7 @@ namespace Autodesk.DataExchange.ConsoleApp.Commands.Options
 {
     internal class ParameterValueDataType:CommandOption
     {
+        public bool IsValidDataType { get; private set; } = false;
         public new ParameterDataType Value { get; private set; } = ParameterDataType.String;
         public ParameterValueDataType()
         {
@@ -17,22 +18,31 @@ public ParameterValueDataType()
 
         public override void SetValue(string value)
         {
+            IsValidDataType = false;
             if (Enum.TryParse(value, true, out ParameterDataType parameterDataType))
             {
                 switch (parameterDataType)
                 {
                     case ParameterDataType.Float64:
+                        IsValidDataType = true;
                         Value = ParameterDataType.Float64;
                         break;
                     case ParameterDataType.Bool:
+                        IsValidDataType = true;
                         Value = ParameterDataType.Bool;
                         break;
                     case ParameterDataType.Int64:
+                        IsValidDataType = true;
                         Value = ParameterDataType.Float64;
                         break;
                     case ParameterDataType.Int32:
+                        IsValidDataType = true;
                         Value = ParameterDataType.Int32;
                         break;
+                    case ParameterDataType.String:
+                        IsValidDataType = true;
+                        Value = ParameterDataType.String;
+                        break;
                 }
             }
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -67,7 +67,7 @@ public override Task<bool> Execute() @@
                 }
                 else if (primitiveGeometryOption.Value == PrimitiveGeometryType.Polyline)
                 {
-                    element = ConsoleAppHelper.GetGeometryHelper().AddPolyline(revitExchangeData);
+                    element = ConsoleAppHelper.GetGeometryHelper().AddPolyline(elementDataModel);
                 }
                 else
                 {
@@ Expand Down @@