Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Bindings: Clean up readme #1283

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

frericp
Copy link
Collaborator

@frericp frericp commented Jul 23, 2021

  • Update module loading section
  • Move shader generation usage to the appropriate place

* Move shader generation usage to the appropriate place
@frericp frericp requested review from kohakukun, sdunkel and muenstc July 23, 2021 09:05
@@ -148,42 +149,6 @@ Documents can be written to strings via the `writeToXmlString` method, and to fi

Note that the `XmlWriteOptions.elementPredicate` option is not supported in JavaScript.

## Maintaining the Bindings
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get confused by this. There are no changes below this point, except for moving the shader gen section to a different place.

Copy link
Collaborator

@sdunkel sdunkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdunkel
Copy link
Collaborator

sdunkel commented Jul 23, 2021

Contributes to #1184

@frericp frericp merged commit 92336a4 into adsk_contrib/dev Jul 23, 2021
@frericp frericp deleted the adsk_contrib/refine_readme branch July 23, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants