Move "unlit_surface" shader to proper library location #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardkwok
changed the title
ashwinbhat
approved these changes
May 12, 2021
There was a problem hiding this comment.
LGTM.
Please update the readme.
https://github.com/autodesk-forks/MaterialX/blob/adsk_contrib/dev/libraries/README.md
Some images might be nice 😄
bernardkwok
added a commit
that referenced
this pull request
May 31, 2021
* Move unlit_shader to pbrlib and no longer make it an "adsk" definitoin. * Rename test file.
bernardkwok
added a commit
that referenced
this pull request
Jul 25, 2021
* Move unlit_shader to pbrlib and no longer make it an "adsk" definitoin. * Rename test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #1148
Move
unlit_surfaceshader to common location and remove adsk namespace.Implementation Graphs
Unit Test Setup