Static analysis fixes

This changelist addresses a handful of static analysis warnings flagged by Cppcheck and MSVC.
autodesk-forks · Mar 17, 2024 · 0067b57 · 0067b57
1 parent 7ede137
commit 0067b57
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/source/MaterialXGenShader/Syntax.cpp b/source/MaterialXGenShader/Syntax.cpp
@@ -151,7 +151,7 @@ string Syntax::getSwizzledVariable(const string& srcName, TypeDesc srcType, cons
         else
         {
             const size_t channelIndex = it->second;
-            if (channelIndex < 0 || channelIndex >= srcMembers.size())
+            if (channelIndex >= srcMembers.size())
             {
                 throw ExceptionShaderGenError("Given channel index: '" + string(1, ch) + "' in channels pattern is incorrect for type '" + srcType.getName() + "'.");
             }
@@ -197,7 +197,7 @@ ValuePtr Syntax::getSwizzledValue(ValuePtr value, TypeDesc srcType, const string
         else
         {
             const size_t channelIndex = it->second;
-            if (channelIndex < 0 || channelIndex >= srcMembers.size())
+            if (channelIndex >= srcMembers.size())
             {
                 throw ExceptionShaderGenError("Given channel index: '" + string(1, ch) + "' in channels pattern is incorrect for type '" + srcType.getName() + "'.");
             }

diff --git a/source/MaterialXRender/GeometryHandler.cpp b/source/MaterialXRender/GeometryHandler.cpp
@@ -12,6 +12,13 @@
 
 MATERIALX_NAMESPACE_BEGIN
 
+namespace
+{
+
+const float MAX_FLOAT = std::numeric_limits<float>::max();
+
+} // anonymous namespace
+
 void GeometryHandler::addLoader(GeometryLoaderPtr loader)
 {
     const StringSet& extensions = loader->supportedExtensions();
@@ -63,7 +70,6 @@ void GeometryHandler::getGeometry(MeshList& meshes, const string& location)
 
 void GeometryHandler::computeBounds()
 {
-    const float MAX_FLOAT = std::numeric_limits<float>::max();
     _minimumBounds = { MAX_FLOAT, MAX_FLOAT, MAX_FLOAT };
     _maximumBounds = { -MAX_FLOAT, -MAX_FLOAT, -MAX_FLOAT };
     for (const auto& mesh : _meshes)

diff --git a/source/MaterialXRenderHw/SimpleWindowWindows.cpp b/source/MaterialXRenderHw/SimpleWindowWindows.cpp
@@ -111,9 +111,9 @@ SimpleWindow::~SimpleWindow()
     if (hWnd)
     {
         _windowWrapper->release();
+        DestroyWindow(hWnd);
     }
 
-    DestroyWindow(hWnd);
     UnregisterClass(_windowClassName, GetModuleHandle(NULL));
 }