Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AppPreferences): set ProxyType to type any #23

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

zze0s
Copy link
Contributor

@zze0s zze0s commented Dec 25, 2023

  • qbit 4.6.x+ uses string None when empty
  • 4.5.5 and below uses integer as the docs v2.8.3 indicate

A proper fix would be to create a custom UnmarshalJSON for the struct. We can do that if it becomes needed.

* qbit 4.3.9 uses string None when empty
* 4.5.5 uses integer as the docs
@zze0s zze0s added the bug Something isn't working label Dec 25, 2023
@zze0s zze0s merged commit 3049cd3 into main Dec 25, 2023
1 check passed
@zze0s zze0s deleted the fix/get-app-preferences-change-type branch December 25, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant