Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/components/routes: add component RoutesMap for entring routes via a map interface #470

Merged
merged 81 commits into from
Nov 15, 2024
Merged

src/components/routes: add component RoutesMap for entring routes via a map interface #470

merged 81 commits into from
Nov 15, 2024

Conversation

maceksimon
Copy link
Contributor

Adds map widget based on openlayers library and its Vue 3 integration.

  • Install vue3-openlayers (boot file openlayers.js)
  • Add RoutesMap - uses library components to enable map features

Add composables:

  • useRoutesMap - controls: saving routes, calculating route length, centering map, style function for rendering route paths with vertices.
  • useRoutesMapDraw - controls: drawing map features, with the undo function
  • useRoutesMapVectorLayer - controls: rendering saved features on the map (without drawing)
  • useGeocoding - controls: naming saved routes via the nominatim.openstreetmap.org API

@maceksimon maceksimon marked this pull request as draft July 12, 2024 07:42
@tmszi tmszi added the enhancement New feature or request label Jul 16, 2024
@tmszi
Copy link
Member

tmszi commented Jul 18, 2024

MNK tiles map service URL https://mnk-osm-tiles.dopracenakole.net/{z}/{x}/{y}.png (URL string should be global app var same as OSM URL string)

You can make simple widget (menu with two items) inside map which allow switch between base maps OSM and MNK.

@tmszi
Copy link
Member

tmszi commented Jul 22, 2024

If you activate one editing tool (draw new line) other tools should be disabled.

@tmszi
Copy link
Member

tmszi commented Jul 22, 2024 •
edited
Loading

  1. Simple tooltip above mouse cursor is still missing
  2. Missing switch widget between base maps OSM, MNK
  3. Undo tool is not working

@maceksimon maceksimon marked this pull request as ready for review July 24, 2024 10:03
@maceksimon
Copy link
Contributor Author

Status

  • Added tooltip with date, transport type and route length.
  • Added select for layer source.
  • Updated undo feature incl. tests (undo now works when tools are switched during drawing and resets after save).

Šimon Macek and others added 28 commits November 14, 2024 11:48
@tmszi
edit single route
750d31a
@tmszi
docs and cleanup
4b3ab53
@tmszi
disabled state for toolbar buttons
6af4f1c
@tmszi
update tests
3ab8bd0
@tmszi
map routes empty state
f7f8f4e
@tmszi
route-list mobile height
ce5bfa3
@tmszi
fix list height desktop
4b92a19
@tmszi
add transport type tooltip label
b9a8dfb
@tmszi
map toolbar dynamic tooltips
7acb82b
@tmszi
add toggle between source types
33d0a6a
@tmszi
set default map source
8adf899
@tmszi
add select menu source
2251cfd
@tmszi
test source select
87ce8a4
@tmszi
fix undo actions for route edits by adding a history entry on load
ec68722
@tmszi
clear edited routes after draw toggle
c22c212
@tmszi
fix types and docs
7df5570
@tmszi
update fixtures for tests and live
e0ea1fb
@tmszi
update and test map toolbar
cada933
@tmszi
routes map toolbar control
f7acdc3
@tmszi
update defaultInteractions to fix tests
5b9a3b9
@tmszi
routes map comments
b774d18
@tmszi
fix history issue and extend tests
39bc84f
@tmszi
update image snapshot
65d5b79
@tmszi
fix eslint error + duplicate tranlation keys
b860326
@tmszi
Regenerate yarn.lock
56203b2
@tmszi
Fix missing vue3-openlayers lib peer dependencies
676c3ec 
Libs: ol, ol-ext, ol-contextmenu

Fix rebase error.
@tmszi
test/cypress/support: fix import material-symbols-sharp icon set
7af3e67 
Error related with upgrade Quasar framework lib to 2.17.2 version

Fix run Cypress component tests.

Cypress component tests error:

```
 1) An uncaught error was detected outside of a test

  0 passing (92ms)
  1 failing

  1) An uncaught error was detected outside of a test:
     TypeError: The following error originated from your test code, not from Cypress.

  > window.Quasar is undefined

When Cypress detects uncaught errors originating from your test code it will automatically fail the current test.

Cypress could not associate this error to any specific test.

We dynamically generated a new test to display this failure.
  at node_modules/quasar/dist/icon-set/material-symbols-sharp.umd.prod.js (http://localhost:9000/__cypress/src/node_modules/.q-cache/vite/spa/deps/quasar_dist_icon-set_material-symbols-sharp_umd_prod.js?v=9d544864:11:7)
  at node_modules/quasar/dist/icon-set/material-symbols-sharp.umd.prod.js (http://localhost:9000/__cypress/src/node_modules/.q-cache/vite/spa/deps/quasar_dist_icon-set_material-symbols-sharp_umd_prod.js?v=9d544864:12:7)
  at __init (http://localhost:9000/__cypress/src/node_modules/.q-cache/vite/spa/deps/chunk-J43GMYXM.js?v=c246f036:8:56)
  at <unknown> (http://localhost:9000/__cypress/src/node_modules/.q-cache/vite/spa/deps/quasar_dist_icon-set_material-symbols-sharp_umd_prod.js?v=9d544864:17:69)
```
@tmszi
Disable run Cypress RoutesMap component tests file
f56af22 
File tests require review/refactor/extends tests.
@tmszi tmszi merged commit 066d82e into auto-mat:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmszi tmszi tmszi left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maceksimon @tmszi