Use explicit T::foo(self, args..) calls in generated methods
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `self.foo(args...)` to `T::foo(self, args...)`. Being more explicit here might avoid bad surprises later (although I can't think of a situation where our current solution breaks).
KodrAus
approved these changes
Oct 10, 2018
| // } | ||
| // | ||
| // With this test we want to make sure, that the call `T::foo` is always | ||
| // unambiguous. Luckily, Rust is nice here. And if e only know `T: Foo`, then |
There was a problem hiding this comment.
nitpick: there's a typo here: missing w in we
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We briefly discussed that in #19
Also: a test and two minor cleanup commits.