Skip to content

Fail early if cargo build returns non-zero exit code #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Fail early if cargo build returns non-zero exit code #33

merged 1 commit into from
Sep 24, 2018

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Sep 24, 2018

Looks like something changed with the --build-plan command so it's no longer linking up dependencies. This PR just inherits the stderr so we can see what cargo is actually doing and blows up if the exit code is non-zero rather than trying to parse an empty build plan.

@KodrAus
Copy link
Member Author

KodrAus commented Sep 24, 2018

I logged rust-lang/cargo#6082 to track an error we've started hitting when attempting to get a build plan in recent nightlys.

@LukasKalbertodt
Copy link
Member

Good idea! I already guessed using the build-plan feature would bring some problems with it down the road °_°

@LukasKalbertodt LukasKalbertodt merged commit d7ba83a into auto-impl-rs:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants