magefile: added combined test coverage support for mage test:all
#2235
+61
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikay <[email protected]>
josephschorr
reviewed
Feb 5, 2025
magefiles/util.go
Outdated
| testArgs := append([]string{ | ||
| "test", | ||
| "-covermode=atomic", | ||
| "-coverprofile=coverage.txt", |
There was a problem hiding this comment.
Won't this overwrite the coverage.txt file when each individual test suite runs? Can you try running mage test:all and ensure it combines the coverage?
There was a problem hiding this comment.
Changed the approach, now each test writes to a different file and removes those files in the end, go tool cover -html=coverage.txt now shows
Signed-off-by: Kartikay <[email protected]>
kartikaysaxena
force-pushed
the
mage-test-coverage
branch
from
46942c5 to
64f1377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348
mage test:allnow generates combined coverprofile aggregated intocoverage.txt