Implement partials syntax parsing #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
| partialNode := p.startNode(dslshape.NodeTypePartial) | ||
| defer p.mustFinishNode() | ||
|
|
||
| // definition ... |
tstirrat15
force-pushed
the
implement-partials-syntax
branch
from
37fb38d to
4d072e8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Implement partials syntax parsing
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tstirrat15
force-pushed
the
implement-partials-syntax
branch
2 times, most recently
from
84b8522 to
4d072e8
Compare
tstirrat15
force-pushed
the
implement-partials-syntax
branch
from
4d072e8 to
8d9b09e
Compare
josephschorr
approved these changes
Jan 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of the MVP of composable schema support. This implements the parsing part of a partials syntax, which can be used to decompose a schema within definitions.
Changes
partialas a keyword