Add support for debug traces in Check Bulk Permission #2193
+963
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
bulk-check-debug
branch
from
ab97060 to
f050f4e
Compare
josephschorr
changed the title
Verolop
reviewed
Jan 7, 2025
josephschorr
force-pushed
the
bulk-check-debug
branch
2 times, most recently
from
ab1a858 to
4887d37
Compare
josephschorr
force-pushed
the
bulk-check-debug
branch
from
4887d37 to
4ba6ceb
Compare
Verolop
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tstirrat15
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Curious - why did adding tracing to bulk check require adding the concept of a node ID? Is this because a bulk check can potentially break up its dispatch to different nodes and we want to identify them? Why wasn't it necessary in the unary check case?
There was a problem hiding this comment.
It didn't; the node ID is an additional benefit for debugging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.