Swap in protovalidate instead of protoc-gen-validate #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
force-pushed
the
use-protovalidate
branch
3 times, most recently
from
852e9db to
5eccedc
Compare
tstirrat15
force-pushed
the
use-protovalidate
branch
9 times, most recently
from
029cae8 to
0647a5f
Compare
|
Gonna hold off on getting this reviewed until authzed/api#124 in |
tstirrat15
force-pushed
the
use-protovalidate
branch
from
0647a5f to
88ba9b6
Compare
|
This is ready now |
miparnisari
approved these changes
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
Description
protoc-gen-validateis incompatible with python 3.13, which is a python version that we want to support. This swaps it out forprotovalidate, which is the successor.Changes
protovalidateas a runtime dependencyvalidatepackageTesting
Review. See that tests pass and that new tests make sense.