Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote BulkCheckPermission to v1 #93

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

alecmerdler
Copy link
Contributor

The BulkCheckPermission API is stable and can be promoted into the v1 PermissionsService.

Resolves #92

@alecmerdler alecmerdler self-assigned this Feb 14, 2024
@alecmerdler alecmerdler force-pushed the bulk-check-permissions-v1 branch from ccaaa00 to db7381b Compare February 14, 2024 16:37
@alecmerdler
Copy link
Contributor Author

Lint is failing because we are re-defining the message types in both experimental_service.proto and permission_service.proto. Need to determine if we should rename the types or keep them only in permission_service.proto.

@alecmerdler alecmerdler changed the title Promote BulkCheckPermission to v1 Promote BulkCheckPermission to v1 Feb 14, 2024
@alecmerdler alecmerdler force-pushed the bulk-check-permissions-v1 branch 3 times, most recently from 024e5ff to d091615 Compare February 14, 2024 19:49
@alecmerdler alecmerdler force-pushed the bulk-check-permissions-v1 branch from d091615 to 5782e2a Compare February 28, 2024 18:34
The 'BulkCheckPermission' API is stable and can be promoted into
the v1 'PermissionsService'.
@alecmerdler alecmerdler force-pushed the bulk-check-permissions-v1 branch from 5782e2a to be92f95 Compare February 28, 2024 19:21
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler requested review from ecordell and removed request for jzelinskie February 28, 2024 19:24
@alecmerdler alecmerdler merged commit 4286d7d into main Feb 28, 2024
3 checks passed
@alecmerdler alecmerdler deleted the bulk-check-permissions-v1 branch February 28, 2024 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move BulkCheckPermission out of experimental
3 participants