Optionally return status on WriteRelationships #106
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a proof of concept for authzed/spicedb#1903.
It adds a
with_status
boolean field onWriteRelationshipsRequest
, and creates a newRelationshipUpdateStatus
type that gets included inWriteRelationshipsResponse
ifwith_status
was true in the request.There are 4 possible statuses:
no_op
: the input operation was a no-op (either aTOUCH
on a relation that already existed as-is, or aDELETE
on a relation that didn't exist, I didn't differentiate between them),created
: the input operation led to a relationship being created (from either aCREATE
orTOUCH
),deleted
: the input operation led to a relationship being deleted (from aDELETE
),updated
: the input operation led to a relationship being updated, and the status includes both the old and the new relationships (from aTOUCH
where caveats differed from what was stored).