Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally return status on WriteRelationships #106

Closed

Conversation

benvernier-sc
Copy link

This PR is part of a proof of concept for authzed/spicedb#1903.

It adds a with_status boolean field on WriteRelationshipsRequest, and creates a new RelationshipUpdateStatus type that gets included in WriteRelationshipsResponse if with_status was true in the request.

There are 4 possible statuses:

  • no_op: the input operation was a no-op (either a TOUCH on a relation that already existed as-is, or a DELETE on a relation that didn't exist, I didn't differentiate between them),
  • created: the input operation led to a relationship being created (from either a CREATE or TOUCH),
  • deleted: the input operation led to a relationship being deleted (from a DELETE),
  • updated: the input operation led to a relationship being updated, and the status includes both the old and the new relationships (from a TOUCH where caveats differed from what was stored).

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant