Change the signatures of the remaining reflection APIs slightly #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
reviewed
May 7, 2024
| message ExpPermissionReference { | ||
| string definition_name = 1; | ||
| string permission_name = 2; | ||
| bool is_permission = 3; |
There was a problem hiding this comment.
Why a bool instead of ExpRelationReference and ExpPermissionReference?
There was a problem hiding this comment.
Because otherwise we'd need two distinct lists to be returned and this is easier to generate
There was a problem hiding this comment.
Do we treat permissions and relations as the same thing anywhere else in the API?
Whether we choose to do this or not just needs to be consistent across the entire API surface. We have to decide whether SpiceDB users need to know that permissions a form relation.
There was a problem hiding this comment.
Yes, we do in all the other API endpoints. We usually name it one way or another (permission or relation), but you can CheckPermission on a relation, for example
josephschorr
force-pushed
the
exp-reflect-changes
branch
from
50bc330 to
d1c59ae
Compare
ecordell
approved these changes
May 7, 2024
jzelinskie
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.