Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hashRouterMode #1270

Closed
wants to merge 1 commit into from
Closed

add hashRouterMode #1270

wants to merge 1 commit into from

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Nov 26, 2023

Partially addresses #971 problem (the part where it's about hashRouter problems):

const manager = new UserManager({
  response_mode: 'query',
  hashRouterMode: true,
  //...
})

@tennox tennox changed the title #971 - add hashRouterMode add hashRouterMode Nov 26, 2023
@tennox
Copy link
Contributor Author

tennox commented Nov 27, 2023

I've just been made aware of this other issue
#734 (comment)

And how it's a bug in the IdentityProvider, appending the queryString after the hash part.

So should I cancel this PR?

@pamapa
Copy link
Member

pamapa commented Nov 27, 2023

So should I cancel this PR?

yes, also see my comment in #971.

@tennox
Copy link
Contributor Author

tennox commented Nov 27, 2023

Got it, closing in favor of pulsejet/nextcloud-oidc-login#251

Thanks :)

@tennox tennox closed this Nov 27, 2023
@pamapa
Copy link
Member

pamapa commented Nov 27, 2023

@tennox I guess it would very worth to add something to the documentation. You could add a "Angular" hash mode section in https://github.com/authts/oidc-client-ts/blob/main/docs/index.md. That would be awesome.

tennox added a commit to tennox/oidc-client-ts that referenced this pull request Nov 28, 2023
After submitting authts#1270 I guess this is the way to go
@tennox tennox mentioned this pull request Nov 28, 2023
2 tasks
dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this pull request Apr 3, 2024
After submitting authts#1270 I guess this is the way to go
@arnaudrolly
Copy link

#1275 (the doc) seems to have been merged, but not #1270 (the functionality) ?

@tennox
Copy link
Contributor Author

tennox commented Nov 26, 2024

#1275 (the doc) seems to have been merged, but not #1270 (the functionality) ?

This PR was an attempt at fixing a problem which is not actually real.
Afaik, the behaviour of this lib is correct, and the IdentityProviders I had been using have a bug of putting the query string in the wrong part of the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants