improve merge claims behavior #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Badisi and @marcoreni Would be awesome if you find time to review this! |
pamapa
force-pushed
the
improve-merge-claims-behavior
branch
2 times, most recently
from
e4b9a37 to
e5b1e7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
+ Coverage 78.16% 78.17% +0.01%
==========================================
Files 45 45
Lines 1731 1732 +1
Branches 345 346 +1
==========================================
+ Hits 1353 1354 +1
Misses 341 341
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pamapa
force-pushed
the
improve-merge-claims-behavior
branch
from
e5b1e7b to
e253265
Compare
pamapa
force-pushed
the
improve-merge-claims-behavior
branch
from
e253265 to
68c1574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes/fixes #1232
Checklist
This merge requests enables a fix for #846 and #852. This MR introduces the new merge behavior and moves all the claims related logic inside a dedicated service.
This code is based on the pre-work done by @marcoreni in #881!