Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: use web crypto instead of cryptojs #1196

Closed
wants to merge 10 commits into from

Conversation

huysentruitw
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f3a805a) 77.92% compared to head (f47a139) 78.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
+ Coverage   77.92%   78.00%   +0.07%     
==========================================
  Files          45       45              
  Lines        1726     1732       +6     
  Branches      346      346              
==========================================
+ Hits         1345     1351       +6     
  Misses        342      342              
  Partials       39       39              
Flag Coverage Δ
unittests 78.00% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OidcClient.ts 92.62% <100.00%> (ø)
src/SigninRequest.ts 100.00% <100.00%> (ø)
src/SigninState.ts 100.00% <100.00%> (ø)
src/State.ts 84.84% <100.00%> (ø)
src/utils/CryptoUtils.ts 91.30% <100.00%> (+1.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa added this to the 3.0.0 milestone Oct 23, 2023
@pamapa
Copy link
Member

pamapa commented Oct 31, 2023

i think now would be a good time to merge this, can you rebase against main, for me the changes look good, i will merge this...

@pamapa pamapa mentioned this pull request Nov 9, 2023
@43081j
Copy link
Contributor

43081j commented Nov 9, 2023

sorry i didn't realise you had pushed another change, i've rebased again.

@pamapa
Copy link
Member

pamapa commented Nov 15, 2023

see #909

@pamapa pamapa closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants