Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Custom sms portal #5000

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Feature: Custom sms portal #5000

wants to merge 59 commits into from

Conversation

tung2744
Copy link
Contributor

No description provided.

tung2744 added 30 commits January 13, 2025 16:34
@tung2744
Support updating twilio secrets in app mutation
cb03d3a
@tung2744
Support querying twilio credentials in app query
a903b2e
@tung2744
Make it easier for portal to distinguish masked secrets and empty sec…
dff817c 
…rets
@tung2744
Support updating custom sms provider secrets in app mutation
85c90ee
@tung2744
Support querying custom sms provider secrets in app query
0e1b7ce
@tung2744
Regenerate graphql schema and types
3667724
@tung2744
Fix error not checked
4ff949d
@tung2744
Setup SMSProviderConfigurationScreen
b44a5a9
@tung2744
Mark sms_provider as deprecated
05de1ca
@tung2744
Add custom sms gateway in navigation bar
f2010c0
@tung2744
Extract ui components from smtp screen
885b0f6
@tung2744
Query the new sms gateway secrets
5563645
@tung2744
Implement header of sms provider screen
524d0ad
@tung2744
Add sms provider section
f54700c
@tung2744
Implement twilio provider form
5b098e3
@tung2744
Fix incorrect type of parameter in mutation
8c4d16f
@tung2744
Fix sms provider secret is not updated in mutation
3de8601
@tung2744
Fix auth token field is not disabled during submit
3d5668d
@tung2744
Add edit button to reveal secrets
2c1230a
@tung2744
Implement webhook sms provider form
9b8b32a
@tung2744
Fix weird ux in revealing secrets in sms provider screen
87968aa
@tung2744
Implement deno hook form in sms provider
3273427
@tung2744
Add descriptions for each providers
2279e7f
@tung2744
Fix type error in e2e
80c632a
@tung2744
Fix incorrect field name in deps
8e8174e
@tung2744
Rename messageServiceSid to messagingServiceSID
efd523b
@tung2744
Rename accountSid to accountSID
eb1259f
@tung2744
Rename customSmsProvider to customSMSProvider
9a222ee
@tung2744
Rename SMSProviderCustomSmsProviderSecrets to SMSProviderCustomSMSPro…
2193679 
…viderSecrets
@tung2744
Rename customSMSProvider to customSMSProviderCredentials
fa74295
tung2744 and others added 23 commits February 4, 2025 14:04
@tung2744
Implement test sms by twilio
8a8b8d0
@tung2744
Implement test sms by webhook
20bd65e
@tung2744
Implement test sms by deno
5dcbde4
@tung2744
Fix mutation name and input type
a2ce56f
@tung2744
Create mutation to send test sms
2059260
@tung2744
Add test sms section
719daf3
@tung2744
Integrate send send sms mutation
df2897c
@louischan-oursky @tung2744
Add custom SMS gateway configuration screen
a55a129 
ref DEV-2301
@tung2744
Provide missing webhook secret when test sms with webhook
dc75c1f
@tung2744
Check the deno script before sending test sms
9dc3086
@tung2744
Run make fmt
287be42
@tung2744
Make messagingServiceSID nullable
760ea15
@tung2744
Update some field descriptions
bb26077
@tung2744
Regenerate schema
fb23939
@tung2744
Abstract SendTestSMS as a method in SMS service
1250d0c
@tung2744
Fix extra divider was shown when custom sms gateway disabled
d9c8dbb
@tung2744
Add feature config custom_sms_provider_disabled
20a31d4
@tung2744
Fix invalid error is always returned
8bc8997
@tung2744
Disable custom sms provider toggle if it is not enabled in feature co…
b75edd1 
…nfig
@tung2744
Make sample script more realistic
ae988aa
@tung2744
Add a environment config to hide features in portal
1e5657b
@louischan-oursky @tung2744
Support sending test SMS
385a585 
ref DEV-2301
@louischan-oursky @tung2744
Add feature flags for custom sms gateway
7ce1b0c 
ref DEV-2431
@tung2744 tung2744 force-pushed the feat-custom-sms-portal branch from bfb06e3 to 7ce1b0c Compare February 4, 2025 06:05
@louischan-oursky louischan-oursky self-requested a review February 4, 2025 06:25
@louischan-oursky louischan-oursky self-assigned this Feb 4, 2025
@tung2744
Copy link
Contributor Author

tung2744 commented Feb 4, 2025

@louischan-oursky The check failed with a lint error:

pkg/portal/graphql/sms_mutation.go cannot import github.com/authgear/authgear-server/pkg/graphqlgo/relay

I ignored this error by updating .make-lint-expect, but I am not sure if we are trying to ban import of github.com/authgear/authgear-server/pkg/graphqlgo/relay for any reason?

@louischan-oursky
Copy link
Collaborator

No, that was a false positive. The import linter was supposed to ban things like importing pkg/lib in pkg/util.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky Awaiting requested review from louischan-oursky

At least 1 approving review is required to merge this pull request.

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tung2744 @louischan-oursky