Restructure localisation resources setup pages #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBH, I don't like this prop
I just copied & paste from LocalizationConfigurationScreen coz it is too complicated
cychiuae
force-pushed
the
restructure-page-layout
branch
from
850fb3c
to
27aa812
Compare
Screen.Recording.2024-06-17.at.4.44.28.PM.movLooks like the color picker preview isn't working? |
|
I checked in the main branch and looks like existing issue, maybe we create another issue to handle it. |
Seems like only background color picker doesn't work |
Production also has this problem. Let me create a issue for it. |
cychiuae
changed the title
|
Created #4346 to follow up |
tung2744
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4290
ref #4291
ref #4334
ref DEV-1381
ref DEV-1382
ref DEV-1418
@tung2744