Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a better matching algorithm to match languages #4067

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Use a better matching algorithm to match languages #4067

merged 9 commits into from
Mar 27, 2024

Conversation

tung2744
Copy link
Contributor

ref #3718 #3454

Benchmark result

goos: darwin
goarch: amd64
pkg: github.com/authgear/authgear-server/pkg/util/intl
cpu: VirtualApple @ 2.50GHz
BenchmarkMatch-8       	   56115	     21034 ns/op
BenchmarkBestMatch-8   	   48363	     24730 ns/op

louischan-oursky
louischan-oursky reviewed Mar 27, 2024
View reviewed changes
pkg/util/intl/match.go Show resolved Hide resolved
pkg/util/intl/match.go Outdated Show resolved Hide resolved
pkg/util/template/translation_test.go Outdated Show resolved Hide resolved
@tung2744
Copy link
Contributor Author

Updated, thanks!

@louischan-oursky louischan-oursky merged commit a439767 into authgear:main Mar 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky left review comments

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tung2744 @louischan-oursky