Skip to content

Commit

Permalink
Update deps as of 2022-07-07
Browse files Browse the repository at this point in the history
  • Loading branch information
carmenlau committed Jul 12, 2022
2 parents b7687c9 + 5beb9bf commit b3322aa
Show file tree
Hide file tree
Showing 29 changed files with 9,870 additions and 14,913 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: ./.github/actions/libvips
- uses: actions/setup-node@v3
with:
node-version: "16.14.0"
node-version: "16.15.1"
- run: npm ci
working-directory: ./portal
- run: npm run typecheck
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
go-version: "1.18.2"
- uses: actions/setup-node@v3
with:
node-version: "16.14.0"
node-version: "16.15.1"
- run: make vendor
- run: make lint
if: ${{ !cancelled() }}
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
go-version: "1.18.2"
- uses: actions/setup-node@v3
with:
node-version: "16.14.0"
node-version: "16.15.1"
- run: make vendor
- run: make binary
- uses: softprops/action-gh-release@v1
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
golang 1.18.2
nodejs 16.14.0
nodejs 16.15.1
18 changes: 10 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,19 +200,21 @@ To setup multi-tenant mode:

### Known issues

graphql must be 15 otherwise `npm run gentype` will fail.
When graphql is ^15.0.0, we will see missing peer dependency of graphql@^14.0.0
See https://github.com/apollographql/apollo-tooling/issues/2232

apollo-language-server may include its own graphql.
That copy must be removed manually from package-lock.json,
otherwise, `npm run gentype` will fail.

As `useBlocker` is removed since react-router-domv6.0.0-beta.7 and have no promise which version will
come back, we introduce the custom `useBlocker` hook by referencing the last commit which this hook
still exist.
See [https://github.com/remix-run/react-router/commit/256cad70d3fd4500b1abcfea66f3ee622fb90874](https://github.com/remix-run/react-router/commit/256cad70d3fd4500b1abcfea66f3ee622fb90874)

NPM has an outstanding issue related to optional native dependencies.
https://github.com/npm/cli/issues/4828
The issue will happen if the following conditions hold:
- The package.json, package-lock.json and node\_modules are in correct state. node\_modules only contain macOS arm dependencies.
- We update the version of parcel and run npm install to update package-lock.json
- package-lock.json becomes invalid.
- npm ci becomes broken on non macOS arm machines
So whenever we want to update dependencies, we first delete node\_modules and package-lock.json.
Then npm install will generate a correct package-lock.json.

When Parcel cannot resolve nodejs globals such as `process` and `Buffer`,
it installs them for us.
But we do not want to do that.
Expand Down
Loading

0 comments on commit b3322aa

Please sign in to comment.