Fix signup rate limit #3307

When rate limited, the nil err is always returned.
authgear · Aug 11, 2023 · 9635307 · 9635307
2 parents 796da93 + 4dbfcff
commit 9635307
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/lib/interaction/nodes/do_create_user.go b/pkg/lib/interaction/nodes/do_create_user.go
@@ -86,7 +86,7 @@ func (n *NodeDoCreateUser) GetEffects() ([]interaction.Effect, error) {
 				// check the rate limit only before running the effects
 				bucket := interaction.SignupPerIPRateLimitBucketSpec(ctx.Config.Authentication, isAnonymous, ip)
 				reservation = ctx.RateLimiter.Reserve(bucket)
-				if reservation.Error() != nil {
+				if err := reservation.Error(); err != nil {
 					return err
 				}
 			}