Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API v2 parse response bodies correctly #66

Closed
wants to merge 5 commits into from
Closed

Fix API v2 parse response bodies correctly #66

wants to merge 5 commits into from

Conversation

CatalinaMoisuc
Copy link

@CatalinaMoisuc CatalinaMoisuc commented Jan 11, 2019

@G-T-P has already contributed with this PR #61

He has changed the APIs to be on Linkedin V2, but the response bodies were not parsed correctly.

G-T-P and others added 5 commits December 18, 2018 14:43
Here is the link to the new documentation:

https://docs.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin?context=linkedin/consumer/context

The api request now has to be:
`GET https://api.linkedin.com/v2/me`

It does not accept parameters any longer and the only scope that are valid are nor r_liteprofile and r_emailaddress which also requires its own api call
Tested it and it works.
The details of waht is returned (which could be greatly improved upon) is documented here:
https://developer.linkedin.com/docs/ref/v2/media-migration
@CatalinaMoisuc CatalinaMoisuc changed the title fix(linkedin-api-v2): parse response bodies correctly Fix API v2 parse response bodies correctly Jan 11, 2019
@CatalinaMoisuc
Copy link
Author

CatalinaMoisuc commented Jan 11, 2019

Seems that there is already a PR opened, including the same fix and upgrading to the v2 APIs: #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants