Skip to content

(feature): add typescript #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

luas10c
Copy link

@luas10c luas10c commented Apr 6, 2025

Description

Add typescript and add support for es modules and commonjs

References

#843 #963 #875 #707

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@luas10c
Copy link
Author

luas10c commented Apr 6, 2025

All code was written using TypeScript. Nowadays, promises are widely used for asynchronous work. Do you think we should keep support for callbacks or only promises? in version ^10

@bonettibruno24
Copy link

Nice work brother, good luck!

@zaack1337
Copy link

good job.

@luas10c
Copy link
Author

luas10c commented Apr 6, 2025

This package rewritten in typescript include types.

@luas10c
Copy link
Author

luas10c commented Apr 6, 2025

You must finish testing today to commit all changes.

@erickgcastro
Copy link

up

@drewdomi
Copy link

drewdomi commented Apr 6, 2025

Good!

@luas10c
Copy link
Author

luas10c commented Apr 6, 2025

Support for nodejs 12, 14 and 16 may be discontinued as these versions have already become obsolete.

@Theus-Gui-Developer
Copy link

good job, this is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants